chore(ci/litjob): fix and optimize GPU related tests
#21290
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhimrazy
requested review from
Borda,
ethanwharris,
justusschock,
lantiga and
tchaton
as code owners
|
It seems the delay in those tests is caused by Test Code
export CUDA_LAUNCH_BLOCKING=0
time python -c "
import torch
from lightning.pytorch.demos.boring_classes import BoringModel
model = BoringModel()
model.example_input_array = torch.randn((4, 32))
model.cuda()
print('Starting compilation with CI env vars...')
import time
start = time.time()
ret = model.to_tensorrt(ir='ts')
end = time.time()
print(f'Compilation took {end - start:.2f} seconds')
"
|
bhimrazy
commented
Nov 4, 2025
bhimrazy
changed the title
bhimrazy
changed the title
ci/litjob): fix and optimize GPU related tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR has the following changes:
Reduced GPU test time by approximately 25–30 minutes.
Two of these tests were taking more than 20 minutes but, when run manually, finished within 5 seconds.
The delay in those tests was mainly caused by
CUDA_LAUNCH_BLOCKING=1.Before:
After:
Fixes a typo by replacing
$(PACKAGE_NAME)with${PACKAGE_NAME}.Fix:
unzipnot found — used in cipytorch-lightning/.actions/pull_legacy_checkpoints.sh
Line 10 in 573828a
Note: It seems there are still
ci/litjobfailures caused by port issues, which require a rerun to pass.PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist